Fixes Burrowers being able to use corrosive acid while underground #6348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zonespace27
approved these changes
May 30, 2024
cm13-github
added a commit
that referenced
this pull request
May 30, 2024
Git-Nivrak
pushed a commit
to Git-Nivrak/cmss13
that referenced
this pull request
Jun 9, 2024
…mss13-devs#6348) # About the pull request Adds an extra check for being burrowed *after* the do_after in corrosive acid. Without this (how things are before this PR) it's possible to start channeling the burrow ability and then start aciding an object, in which case the acid will finish applying while you're underground since you've already cleared the check for being burrowed. <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> # Explain why it's good for the game Obviously unintended behavior and I *have* seen people in-game abusing this. It's quite awful to play against since there is absolutely zero counterplay. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. https://streamable.com/22ualc </details> # Changelog :cl: fix: Fixed an exploit that allowed Burrowers to apply acid to objects while underground /:cl:
Git-Nivrak
pushed a commit
to Git-Nivrak/cmss13
that referenced
this pull request
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Adds an extra check for being burrowed after the do_after in corrosive acid.
Without this (how things are before this PR) it's possible to start channeling the burrow ability and then start aciding an object, in which case the acid will finish applying while you're underground since you've already cleared the check for being burrowed.
Explain why it's good for the game
Obviously unintended behavior and I have seen people in-game abusing this.
It's quite awful to play against since there is absolutely zero counterplay.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.https://streamable.com/22ualc
Changelog
🆑
fix: Fixed an exploit that allowed Burrowers to apply acid to objects while underground
/:cl: